This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Add async scan algorithms #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
commented
Aug 6, 2020
alliepiper
added a commit
to alliepiper/thrust
that referenced
this pull request
Aug 6, 2020
…ions. This partially reverts 7ff227a and fixes NVIDIA#1250. I'm not sure why changing these broke the tests, but since these usages are just testing details that are being refactored by NVIDIA#1251 let's just revert the change for now. The test failures were only happening on GCC, MSVC was fine with both versions of these functions, so it may be a compiler issue.
alliepiper
force-pushed
the
feature/async_scan_algos
branch
from
45c8380
to
87ae049
Compare
alliepiper
added a commit
that referenced
this pull request
Aug 12, 2020
…ions. This partially reverts 7ff227a and fixes #1250. I'm not sure why changing these broke the tests, but since these usages are just testing details that are being refactored by #1251 let's just revert the change for now. The test failures were only happening on GCC, MSVC was fine with both versions of these functions, so it may be a compiler issue.
alliepiper
force-pushed
the
feature/async_scan_algos
branch
2 times, most recently
from
d6ae713
to
7caa692
Compare
alliepiper
force-pushed
the
feature/async_scan_algos
branch
4 times, most recently
from
ab507ce
to
9e7dfe2
Compare
alliepiper
force-pushed
the
feature/async_scan_algos
branch
from
9e7dfe2
to
c953231
Compare
alliepiper
force-pushed
the
feature/async_scan_algos
branch
from
c953231
to
c236ed8
Compare
|
The "large indices" tests are currently failing because temporary memory allocation fails for the larger problem sizes. This doesn't happen for the synchronous scan (which uses a custom implementation instead of just calling |
trivialfis
reviewed
Oct 6, 2020
alliepiper
force-pushed
the
feature/async_scan_algos
branch
from
c236ed8
to
3ff9d84
Compare
|
DVS CL: 29371528 |
|
Latest round of DVS runs show the following issues on Clang: |
alliepiper
force-pushed
the
feature/async_scan_algos
branch
from
56c0eec
to
a071c17
Compare
|
run tests |
1 similar comment
|
run tests |
- iterator_value_t - iterator_pointer_t - iterator_reference_t - iterator_difference_t - iterator_system_t
alliepiper
force-pushed
the
feature/async_scan_algos
branch
from
a071c17
to
888512b
Compare
|
run tests |
alliepiper
force-pushed
the
feature/async_scan_algos
branch
from
888512b
to
e1b3caa
Compare
|
run tests |
|
DVS CL: 29473661 |
alliepiper
added
testing: internal ci in progress
alliepiper
added
testing: gpuCI passed
brycelelbach
approved these changes
Jan 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite: NVIDIA/cub#210